Memes

45550 readers

992 users here now

Rules:

Be civil and nice.
Try not to excessively repost, as a rule of thumb, wait at least 2 months to do it if you have to.

founded 5 years ago

MODERATORS

[email protected]

I was able to learn React though (lemmy.world)

submitted 10 months ago by [email protected] to c/[email protected]

14 comments fedilink hide all child comments

all 16 comments

sorted by: hot top controversial new old

[–] [email protected] 15 points 10 months ago

I’ve been there, but over the years I’ve gotten better at avoiding being in this situation.

If you are implementing something for yourself, and merging it back upstream is just a bonus, then by all means jump straight to implementing.

However, it’s emotionally draining to implement something and arrive at something you’re proud of only to have it ignored. So do that legwork upfront. File a feature request, open a discussion, join their dev chat - whatever it is, make sure what you want to do is valued and will be welcomed into the project before you start on it. They might even nudge you in a direction that you hadn’t considered before you started.

Be a responsible dev and communicate before you do the work.

[–] [email protected] 9 points 10 months ago

Even better when someone makes the exact same PR and it gets merged a few days after being opened and yours left unreviewed.

[–] [email protected] 8 points 10 months ago

[–] [email protected] 5 points 10 months ago* (last edited 10 months ago)

I once made a PR changing a = f(b) from a = "" if b == "" else f(b). About six months later still in pending review. I get that people have their own shit but damn.

edit) Sorry. Clarified the code.

[–] [email protected] 4 points 10 months ago

If that's happening to you that's crazy. GitHub is way too noisy though. I get 30 notifications on that apps notification widget though for just bullshit I didn't even know I signed up for or snyk or some other garbage.

[–] [email protected] 3 points 10 months ago

"closed by stalebot"

[–] [email protected] 3 points 10 months ago

This is why I always ask if the maintainers are open to a PR first.

[–] [email protected] 3 points 10 months ago

Somebody please fork reprepro, there's a super useful bugfix in one and a super useful feature in the other but I want both.

The bugfix is the zstd decompression-cancel race condition bug and the feature is multiple versions per package but they're both super stale.
Maybe...
Maybe I can fork it...

[–] [email protected] 2 points 10 months ago

Or worse, ban you from their GitHub repository without any reply or explanation

[–] [email protected] 2 points 10 months ago (3 children)

And this is why I don't contribute. Or at least I'll ask a question about whether or not something would be a desired feature and if I don't get a clear yes or no by someone who can actually approve a PR, I. ain't. coding. shit.

[–] [email protected] 1 points 10 months ago

Fair enough, but as someone who has worked closely with the Decky Loader maintainers and contributed my own stand alone plugin I get it. We basically all have day jobs as devs and it can be mentally taxing to do more PRs at home. Not to mention sometimes there's just not enough time in the day, and I don't even have kids.

Maintainers are ultimately volunteers doing work with hundreds of dollars an hour for free. I've had some PRs take 20+ days to be looked at, it's just how it goes.

[–] [email protected] 1 points 10 months ago

You're framing this as if it were something unusual. Unsolicited PRs are a no-go in my opinion. It's just basic communication and collaboration to align with the maintainers whether a change is actually required or not.

[–] [email protected] 0 points 10 months ago* (last edited 10 months ago) (1 children)

That's the fucking worst, when you put all this work into a free and open project only for the lead to be like "nah don't like it"

Free and Open as in, free to do the work for them and Open for it to be rejected for almost no reason.

[–] [email protected] 1 points 10 months ago

A project is in no way, shape, or form obliged to to accept and maintain your code, especially if it's not a feature they want. If you want your feature so badly, maintain a soft-fork yourself. Don't want to put in that effort yourself? Then why should the project maintainers?