this post was submitted on 24 Oct 2023
711 points (97.6% liked)

Programmer Humor

19817 readers
47 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 60 points 1 year ago (5 children)

Commenting well is a highly advanced skill. I generally prefer no comments on code since it's less likely to confuse people and I'll merrily purge auto-doc comments and anything like

// getId() returns an id

That comment has negative value.

[–] [email protected] 24 points 1 year ago

I can't help it, I always get the mental image of hands clapping sarcastically when I see something like that.

[–] [email protected] 10 points 1 year ago (3 children)

In my experience refactoring lots and lots of crappy code left by devs long gone, a dev who can write useful comments is by and large a dev who can write code clean and simple enough not to need them. If the code doesn't have informative names and clear separation of concern, chances are a comment won't help because the dev didn't really know what they did that worked in the first place.

[–] [email protected] 14 points 1 year ago

Generally, yes. However I have been known to document exactly why I'm doing something incredibly stupid - because it's required but a stupid third party library which, despite being awful, is still better than implementing it myself as a refactor.

[–] [email protected] 3 points 1 year ago

a dev who can write useful comments is by and large a dev who can write code clean and simple enough not to need them.

my boss is great in this regard and also always has to keep reminding us to write unit tests 😅

[–] [email protected] 9 points 1 year ago (2 children)

Comments should only be used to describe stuff that’s otherwise difficult to convey with code.

[–] [email protected] 18 points 1 year ago (1 children)

The best explanation I've ever heard is:

Comments should state the 'Why' never the 'What'.

[–] [email protected] 1 points 1 year ago

There are some cases though where the code is just complicated for reasons outside of your control, in which case "what" comments are good - but they should never be taken at face value, but only used as a first step in understanding the code. There's a significant risk of the code not actually doing what the comment says.

[–] [email protected] 3 points 1 year ago (1 children)

Yeah. Most of the time I use comments in my algorithms, as they often use some weird optimized black magic which are difficult to understand without comments.

[–] [email protected] 1 points 1 year ago

Like don't set this value to the obvious default. Bad stuff happens

[–] [email protected] 6 points 1 year ago (1 children)

I write a lot of fairly simple scripts in Bash and PowerShell that should be easily understood by anybody else with moderate experience in the language, but I leave a lot of obvious comments because my coworkers don't write any code and are extremely skittish about my automations. I add them basically to quell their fears.

[–] [email protected] 9 points 1 year ago (1 children)

Why are coworkers who don't write any code in the codebase?

[–] [email protected] 7 points 1 year ago* (last edited 1 year ago)

These are scripts that manage stuff on a few hundred user endpoints and a few servers. They were doing basically everything manually until I got here, and the only way I could get them on board with my slow introduction of automation is to let them see it. I have to ensure things don't get too long, complex, or hard to explain, or they start getting nervous.

[–] [email protected] 4 points 1 year ago

I'd rather teach people to comment well through my reviews. Much easier to understand two lines of well written function description in English than 20 lines of code.