this post was submitted on 22 Jul 2023
11 points (100.0% liked)

Programmer Humor

19594 readers
2214 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
 
top 7 comments
sorted by: hot top controversial new old
[–] [email protected] 1 points 1 year ago (1 children)

I mean, it should be a protected branch to prevent against that.

[–] [email protected] 1 points 1 year ago (1 children)

Sometimes there's no other option when someone merged develop into master just before a critical bug was found.

[–] [email protected] 0 points 1 year ago (1 children)

You can always revert (i.e. undo in a new commit) the faulty commit. That will keep the history. This meme is not just about pushing straight to master, it's about push --force which overwrites the remote branch completely, changing history.

[–] [email protected] 1 points 1 year ago (1 children)

Sometimes there's only the nuclear option left, I have only done it a few times, someone merged a major refactoring and we ended up reverting by changing history.

I have also observed that when you revert with git revert and then merge back some time later git can get confused about if a commit was merged or not.

Mind you we didn't use git flow or other smart processes to our own regret.

[–] [email protected] 1 points 1 year ago* (last edited 1 year ago) (1 children)

git can get confused about if a commit was merged or not.

You have to revert the revert before re-merging the branch. Otherwise git keeps track of the commits that you reverted and doesn't apply them ever again.

See: https://github.com/git/git/blob/master/Documentation/howto/revert-a-faulty-merge.txt

[–] [email protected] 1 points 1 year ago

Thanks for the info, I think that's exactly what we didn't do.

[–] [email protected] 1 points 1 year ago

I love how they're smiling