this post was submitted on 16 Nov 2023
320 points (98.8% liked)
Programmer Humor
19480 readers
181 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
I'd be pulled up at my job for any PR exceeding a few hundred lines. I don't even know what they'd do if I just dropped a 15000 line stinker.
Just a few hundred?
That's seems awfully short no? We're talking a couple hours of good flow state, that may not even be a full feature at that point ๐ค
We have folks who can push out 600-1k loc covering multiple features/PRs in a day if they're having a great day and are working somewhere they are proficient.
Never mind important refactors that might touch a thousand or a few thousand lines that might be pushed out on a daily basis, and need relatively fast turnarounds.
Essentially half of the job of writing code is also reviewing code, it really should be thought of that way.
(No, loc is not a unit of performance measurement, but it can correlate)
To be honest, I agree they should be able to be larger at times.
I had a lot of disagreements when I was on a new codebase, knew what I was doing and I was able to push a lot of code out each day.
The idea is to have them small, easily readable with a tight feedback loop. I argued that bootstrapping a project will have a lot of new code at once to lay the foundations and my communication with the team was enough feedback. If I split it up, each PR would have been an incomplete idea and would have garnered a bunch of unnecessary questions.
That said, I think it's generally pretty easy to put out multiple PRs in a day, keeping them small and specific. As you say, half of the job is reading code and it's nicer to give my coworkers a set of PRs broken down into bite sized pieces.