this post was submitted on 14 Nov 2023
734 points (97.1% liked)

Programmer Humor

24317 readers
1212 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS
734
Merge then review (programming.dev)
submitted 2 years ago* (last edited 2 years ago) by [email protected] to c/[email protected]
 

Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don't let code become stale.

you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 2 points 2 years ago

Ah. Yeah those kind of nitpicks are annoying. We try to specify when comments are blocking or non blocking on reviews.

But I definitely block a lot of reviews over no tests, bad tests, no error handling, failed linting. And the occasional "this doesn't do what the ticket asked for"