Programmer Humor

19817 readers

47 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

Keep content in english
No advertisements
Posts must be related to programming or programmer topics

founded 2 years ago

MODERATORS

[email protected]

711

I am God's greatest programmer (lemmy.world)

submitted 1 year ago by [email protected] to c/[email protected]

47 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[+] [email protected] 13 points 1 year ago* (last edited 1 year ago) (1 children)

[deleted]

[–] [email protected] 10 points 1 year ago (1 children)

If you are creating an alternative implementation and leaving the old one in place, you are not fixing a problem, you are just creating a new one (and a third one because you have duplication of logic).

Either refactor the old function so that it transparently calls the new logic or delete the old function and replace all the existing usage with usage of the new one. It does not need to happen as a single commit. You can check in the new function, tell everyone to use it, and clean up usage of the old one. If anyone tries to use the old implementation, call them out in a code review.

If removing or replacing the old implementation is not possible, at least mark it as deprecated so that anyone using it gets a warning.