Programmer Humor

19488 readers

646 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

Keep content in english
No advertisements
Posts must be related to programming or programmer topics

founded 1 year ago

MODERATORS

[email protected]

928

Looks good to me 👍 (i.ibb.co)

submitted 4 months ago by [email protected] to c/[email protected]

26 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 47 points 4 months ago (2 children)

I always try to review the code anyway. There's no guarantee that what they wrote is doing what you want it to do. Sometimes I find the person was told to do something and didn't realize it actually needs to do Y and not just X, or visa versa.

[–] [email protected] 20 points 4 months ago (1 children)

I like to shoot for the middle ground: skim for key functions and check those, run code locally to see if it does roughly what I think it should do and if it does merge it into dev and see what breaks.

Small PRs get nitpicked to death since they're almost certainly around more important code

[–] [email protected] 10 points 4 months ago

Especially when you see a change in code, but not in tests ☠️

[–] [email protected] 2 points 4 months ago (1 children)

Yes, I always review the code, just avoid nitpicking the hell out of it.

[–] [email protected] 1 points 4 months ago

Yeah, sorry, totally misread your comment.