this post was submitted on 11 Jun 2024
450 points (99.1% liked)
Programmer Humor
19512 readers
418 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Better than a 200 JSON reply containing the 4xx. "Aay it worked!" "oh."
Worked at a company where the previous devs had implemented their own frameworks for front and backend. Obviously 200 was the only possible code.
Not even 418?! Uncultured swine.
This legitimately happened to me a few months ago. A vendor API was returning HTTP 200 with the error details embedded in the JSON response. It was a pain in the ass to troubleshoot.
Yeah, had that happen a few years ago, thankfully there was a consistent status attributes in the response that I could use but still, annoying
I guess I might be evil but when I made APIs for my projects I do this, since I blindly accept the response then look at the JSON to see if it was accepted or not
Something like
if (body_has(JSON)) do_stuff_with(JSON) // including error handling if the response has an error else error_no_json()I do this since I feel like JSON errors should be separate from HTTP errors
The problem I ran into was the response returned a JSON body, but then had an "error" attribute that was returned in it that had the error details. So we were parsing the JSON and loading elements into our database. We were hitting the API passing in a datetime of when the last success job was run, so basically saying "give me everything that's changed since I last called you."
So yeah, eventually we noticed we were missing small chunks of data. It turned out that every time the API errored out, we'd get a valid JSON response that contained the error message, but it didn't have the attributes we were looking for. So didn't load anything, but updated our timestamp to say when our last successful call was.
Huge pain in the ass to troubleshoot, because the missing data was scattered with no distinguiable pattern.
Why not respond with the appropriate HTTP Code, and then also put the same code in the json?
That would have been fine for me too. I don't own the API, so I can only speak from a consumer perspective in saying: I don't want a HTTP 200 if my request didn't succeed.
“Task failed successfully”
what the fuck
I've had this so often... very frustrating.
I like to think the 400 within a 200 is for "look, I managed to reply to you. But there is bad news"
You can give a 400 response a body though. It doesn't stop you from replying.
regardless, its a big red flag for a poorly designed api
Oh I agree! It was so annoying.