this post was submitted on 26 Oct 2023
925 points (96.5% liked)
Programmer Humor
19551 readers
666 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
I am really happy when people are quite strict in code reviews, it makes me feel safer and I get to learn more.
Nothing worse than some silent approvals with no real feedback. What if I missed something obvious... and now it's merged.
To be fair, I also enjoy getting my grammar corrected. I'm juggling 3 languages and things can get messy.
Like the other guy, I also read your comment twice looking for mistakes but found none.
You should of left something to fix!
๐
Edit: I'm glad there so many people who are as passionate about the correct spelling of "should've" as I am. I was testing you all, and you passed!
Correcting the reviewer.
Notes: "should of" isn't valid, should implies a verb, of isn't a verb. I expect you meant "should have". Please recall this in future submissions.
They should of course keep that in mind, but it's not that "should" should always be followed by a verb directly. The problem is that "of" in this context is a mishearing/spelling of "have", so they should in this case have written it like that instead.
I love that you used "should of" in a valid sentence.
Except that it would be "they should, of course,".
I would argue that "should of" is just a naive written rendition of the spoken contraction "should've". They are homophones, so it's a completely understandable error among those without the relevant education or background. I know only English and was in Grade 9 at a different school before someone corrected me.