this post was submitted on 26 Oct 2023
925 points (96.5% liked)

Programmer Humor

19564 readers
1412 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 94 points 1 year ago (23 children)

I am really happy when people are quite strict in code reviews, it makes me feel safer and I get to learn more.

Nothing worse than some silent approvals with no real feedback. What if I missed something obvious... and now it's merged.

To be fair, I also enjoy getting my grammar corrected. I'm juggling 3 languages and things can get messy.

[–] [email protected] 11 points 1 year ago* (last edited 1 year ago) (11 children)

Like the other guy, I also read your comment twice looking for mistakes but found none.
You should of left something to fix!
😏

Edit: I'm glad there so many people who are as passionate about the correct spelling of "should've" as I am. I was testing you all, and you passed!

[–] [email protected] 15 points 1 year ago (10 children)

Correcting the reviewer.
Notes: "should of" isn't valid, should implies a verb, of isn't a verb. I expect you meant "should have". Please recall this in future submissions.

[–] [email protected] 3 points 1 year ago* (last edited 1 year ago)

Notes: “should of” isn’t valid, should implies a verb, of isn’t a verb. I expect you meant “should have”. Please recall this in future submissions.

😏

load more comments (9 replies)
load more comments (9 replies)
load more comments (20 replies)